v3 - clean stega from salaries data string #673
Merged
+38
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since salaries data is encoded as a simple string, Sanity assumes it's fine to apply stega to it. But JSON.parse begs to differ...
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathiazom
force-pushed
the
fix/v3-stega-clean-salaries-data-string
branch
from
c331617 to
1d3dd88
Compare
anemne
approved these changes
Sep 18, 2024
christinaroise
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since salaries data is encoded as a simple string, Sanity assumes it's fine to apply stega to it in preview. But
JSON.parsebegs to differ, causingCompensationsPreviewto crash. This has now been fixed by using the stega cleaning utilitystegaCleanon the salaries data object.Updated README.md to include a section explaining this pitfall.
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: